[lint] replaces black formatting with ruff #14132
Conversation
|
oh wait, okay, i'm gonna see if there's an equivalent to |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iris-garden
force-pushed
the
lint/ruff-replace-black-format
branch
from
97b15b3
to
44d9c7e
Compare
|
okay, enabled the |
|
Interesting, PEP 8 does have an opinion about triple-quoted strings. FWIW, I'm happy to go stricter in the future and allow string normalization and all that (assuming other folks are on board), but I appreciate you aligning the configs for this PR! |
| f' dataset {name}.\n' | ||
| f'Available platforms: {clouds}.') | ||
| raise ValueError( | ||
| f'Cloud platform {repr(cloud)} not available for' f' dataset {name}.\n' f'Available platforms: {clouds}.' |
There was a problem hiding this comment.
This line is a little unfortunate. Let's combine them into one f-string.
|
fixed up the dev requirements, and updated the pre-commit hook, and in the process realized i had only run EDIT: i misunderstood how the pre-commit hooks work, and apparently it only runs them on the files you have changed, but i think it's still worth it to format across the repo, not just in the places we check with also i personally would love if our quotes were consistent as well! i'll ask on zulip how ppl feel about that |
ruffis faster thanblackwhen formatting Pythonfiles, so this change replaces the formatting checks for our files with calls toruffinstead ofblack, and runsruff formaton all files that would cause those checks to fail.